Repository navigation
test(designsystem): vcase pilot for three gallery screenshot tests - #5140
Closed
stamp-build[bot] wants to merge 3 commits into
Closed
stamp-build[bot] wants to merge 3 commits into
stamp-build[bot] wants to merge 3 commits into
Conversation
Moves the empty state, save status and composer drop overlay gallery screenshots onto vcase 0.1.0 (build.raft.vcase, maven.artifacts.botiverse.dev): @vcase cases in src/desktopVcase, rendered by RaftVCaseHost, verified with zero tolerance against screenshots/vcase/desktop-skiko. recordRoborazziDesktop records them too. LegacyGoldenParityTest gates deleting the old tests on pixel-equal goldens. Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com> Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…hotGoldens covers it; a missing file failed validation) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…xel-identical to the legacy ones Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
This was referenced Nov 20, 2026
Contributor
Author
|
Merged by Stamp in batch |
stamp-build Bot
added a commit
that referenced
this pull request
Nov 20, 2026
…5162) * test(designsystem): drop legacy screenshot tests replaced by vcase The vcase pilot (#5140) recorded goldens for empty state, save status and the composer drop overlay that matched the legacy RaftScreenshot goldens pixel for pixel. Remove the three legacy gallery tests, their six goldens and the one-off LegacyGoldenParityTest migration gate. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> * test(designsystem): update vcase manifest source lines Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> --------- Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
stamp-build Bot
added a commit
that referenced
this pull request
Nov 20, 2026
…5176) * test(designsystem): vcase cases for eight more gallery screenshot tests Second vcase batch, after the pilot (#5140, #5162). Each case copies its legacy RaftScreenshot test's content; the legacy tests and goldens stay until LegacyGoldenParityTest (re-introduced for this batch) shows the recorded vcase goldens equal them pixel for pixel. - TextFieldContainerAddon: ds.text-field-container-addon.gallery - MessageEmbed: ds.message-embed.gallery - TaskCompactList: ds.task-compact-list.gallery - ModeBar: ds.mode-bar.gallery - SelectionToolbar: ds.selection-toolbar.gallery, .fit, .dock - TaskHeadComponents: ds.description-list.inline, ds.timeline.gallery - PullDownPanel: ds.pull-down-panel.default - MessageAttachmentCard: ds.message-attachment-card.gallery vcase 0.1.0 -> 0.1.1 (a case that only moved within its file is a note, not a manifest failure). Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> * test(designsystem): vcase goldens for batch 2 (recorded on CI run 44810868569) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> --------- Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of moving screenshot tests onto vcase (Raft #proj-mobile:#211, design agreed in #proj-mobile:d26bb175).
What
@VCasecases incompose/designsystem/src/desktopVcase, rendered byRaftVCaseHostand checked with zero tolerance.build.raft.vcase:vcase-compose-desktop:0.1.0on maven.artifacts.botiverse.dev (public namespace, no CI token);settings.gradle.ktsaddsincludeGroup("build.raft.vcase")to that repository.compose/designsystem/screenshots/vcase/desktop-skiko/, manifest atscreenshots/vcase/vcase.manifest.json.recordRoborazziDesktoprecords them too, so the existingrecord_screenshotsdispatch collects them; no workflow change.LegacyGoldenParityTestcompares each vcase golden with the legacy Roborazzi golden it replaces. The old tests are deleted only after it passes (follow-up PR).Status
Goldens are not committed yet: next push adds them from a
record_screenshots=truerun. Until thenDesignSystemVCasesfails on missing goldens.No user-visible change, no changeset.
🤖 Generated with Claude Code