Skip to content

test(designsystem): vcase pilot for three gallery screenshot tests - #5140

Closed
stamp-build[bot] wants to merge 3 commits into
mainfrom
agent/sindresorhus/vcase-ds-pilot
Closed

stamp-build[bot] wants to merge 3 commits into
mainfrom
agent/sindresorhus/vcase-ds-pilot

Conversation

@stamp-build

@stamp-build stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

sindresorhus from raft opened this pull request through Stamp
View in Stamp →


First step of moving screenshot tests onto vcase (Raft #proj-mobile:#211, design agreed in #proj-mobile:d26bb175).

What

  • Three design-system gallery screenshots (empty state, save status, composer drop overlay) are written as @VCase cases in compose/designsystem/src/desktopVcase, rendered by RaftVCaseHost and checked with zero tolerance.
  • vcase comes from build.raft.vcase:vcase-compose-desktop:0.1.0 on maven.artifacts.botiverse.dev (public namespace, no CI token); settings.gradle.kts adds includeGroup("build.raft.vcase") to that repository.
  • Goldens live at compose/designsystem/screenshots/vcase/desktop-skiko/, manifest at screenshots/vcase/vcase.manifest.json. recordRoborazziDesktop records them too, so the existing record_screenshots dispatch collects them; no workflow change.
  • LegacyGoldenParityTest compares each vcase golden with the legacy Roborazzi golden it replaces. The old tests are deleted only after it passes (follow-up PR).

Status
Goldens are not committed yet: next push adds them from a record_screenshots=true run. Until then DesignSystemVCases fails on missing goldens.

No user-visible change, no changeset.

🤖 Generated with Claude Code

sindresorhus and others added 3 commits November 20, 2026 07:58
Moves the empty state, save status and composer drop overlay gallery screenshots onto vcase 0.1.0 (build.raft.vcase, maven.artifacts.botiverse.dev): @vcase cases in src/desktopVcase, rendered by RaftVCaseHost, verified with zero tolerance against screenshots/vcase/desktop-skiko. recordRoborazziDesktop records them too. LegacyGoldenParityTest gates deleting the old tests on pixel-equal goldens.

Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com>
Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…hotGoldens covers it; a missing file failed validation)

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…xel-identical to the legacy ones

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
@stamp-build

stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Merged by Stamp in batch b68f350735cf867cd412db98f8bdf887: 101700f . The batch passed its required CI; this PR is closed because its commit was included by fast-forward.

Review in stamp.build

@stamp-build stamp-build Bot closed this Nov 20, 2026
stamp-build Bot added a commit that referenced this pull request Nov 20, 2026
…5162)

* test(designsystem): drop legacy screenshot tests replaced by vcase

The vcase pilot (#5140) recorded goldens for empty state, save status and
the composer drop overlay that matched the legacy RaftScreenshot goldens
pixel for pixel. Remove the three legacy gallery tests, their six goldens
and the one-off LegacyGoldenParityTest migration gate.

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

* test(designsystem): update vcase manifest source lines

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

---------

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
stamp-build Bot added a commit that referenced this pull request Nov 20, 2026
…5176)

* test(designsystem): vcase cases for eight more gallery screenshot tests

Second vcase batch, after the pilot (#5140, #5162). Each case copies its
legacy RaftScreenshot test's content; the legacy tests and goldens stay
until LegacyGoldenParityTest (re-introduced for this batch) shows the
recorded vcase goldens equal them pixel for pixel.

- TextFieldContainerAddon: ds.text-field-container-addon.gallery
- MessageEmbed: ds.message-embed.gallery
- TaskCompactList: ds.task-compact-list.gallery
- ModeBar: ds.mode-bar.gallery
- SelectionToolbar: ds.selection-toolbar.gallery, .fit, .dock
- TaskHeadComponents: ds.description-list.inline, ds.timeline.gallery
- PullDownPanel: ds.pull-down-panel.default
- MessageAttachmentCard: ds.message-attachment-card.gallery

vcase 0.1.0 -> 0.1.1 (a case that only moved within its file is a
note, not a manifest failure).

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

* test(designsystem): vcase goldens for batch 2 (recorded on CI run 44810868569)

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

---------

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants